Change: Progressive file retrieval implemented #504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added a flag (\isSyncEngineRunning\) to the polling process. - This flag is set to \ rue\ when the sync engine thread is running. - The flag is reset to \ alse\ once the sync engine thread has finished its work. - This allows better management and monitoring of the sync engine state during polling operations. - Updated the corresponding tests to reflect this new behavior. Related issue: /PB-2244
This change ensures that the queries do not execute simultaneously, improving system stability.
Made several UI adjustments to improve user experience as per the requirements in the Jira ticket https://inxt.atlassian.net/browse/PB-2192.
- Made modifications to improve usability and design as per ticket requirements. - Adjusted styles and layout to align with specifications. - Additional changes to meet established design guidelines. Details at: https://inxt.atlassian.net/browse/PB-2177
sg-gs
reviewed
Jul 10, 2024
| // const start = Date.now(); | ||
| Logger.info('Starting remote to local sync'); | ||
| Logger.info('Checking if we are in a valid state to start the sync'); | ||
|
|
||
| const testPassed = this.smokeTest(); | ||
| // const testPassed = this.smokeTest(); |
There was a problem hiding this comment.
Using a smoke test is a good practise, so you can ensure everything is in the situation you expect to find before doing any step. If this does not fit your current implementation, please change the smoke test implementation to adapt to the circumstances and expectations you would like to find to run a successful sync.
|
Hi Sergio,
Thanks for your comments on the smoke test.
I totally agree, using a smoke test is a good practice to make sure
everything is in order before syncing. Right now, I’ve commented it out
because we’re in the middle of debugging.
I’ll adjust the smoke test to better fit our current situation and needs.
Once I’m sure it covers everything necessary, I’ll add it back in to ensure
a successful sync.
Thanks for your patience.
<https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail>
Libre
de virus.www.avast.com
<https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail>
<#DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2>
…On Wed, Jul 10, 2024 at 2:39 PM Sergio Gutiérrez ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In src/apps/main/remote-sync/RemoteSyncManager.ts
<#504 (comment)>
:
> // const start = Date.now();
Logger.info('Starting remote to local sync');
Logger.info('Checking if we are in a valid state to start the sync');
- const testPassed = this.smokeTest();
+ // const testPassed = this.smokeTest();
Using a smoke test is a good practise, so you can ensure everything is in
the situation you expect to find before doing any step. If this does not
fit your current implementation, please change the smoke test
implementation to adapt to the circumstances and expectations you would
like to find to run a successful sync.
—
Reply to this email directly, view it on GitHub
<#504 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A7XCWVCGOJGSW54UUGP3LPLZLVWWTAVCNFSM6AAAAABJOK2GLOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCNRZHA2DINBTGI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
--
*P*lease consider your
evironmental responsibility: Before printing
this e – mail or any other
document, ask yourself whether you need a hard
copy.
Confidentiallity Notice: The
information in this document and
attachements is confidential and may also be
legaly privileged. It is
intended only for the use of the name recipient.
Internet communications
are not secure and therefore Shokworks, Inc. does not
accept any legal
responsibility for the contents of this message. If you are
not the
intended recipient, please notify us inmediately and then delete this
document. Do not disclose the contents of this document to any other
person,
nor take any copies. Violation of this notice may be unlawful.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.